Skip to content

chore: adjust UI for default osd #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
deepin-bot merged 1 commit into from
Apr 7, 2025
Merged

chore: adjust UI for default osd #1079

deepin-bot merged 1 commit into from
Apr 7, 2025

Conversation

@18202781743
Copy link
Contributor

@18202781743 18202781743 commented Apr 7, 2025 •
edited by mhduiy
Loading

  • update icons.
  • adjust margin between icon and text.

pms: BUG-311279

Summary by Sourcery

Update OSD (On-Screen Display) icons and adjust text margin in the notification panel

Enhancements:

  • Reduce left margin for text in the OSD to 16 pixels from 20 pixels

Chores:

  • Modify icon names for various system state indicators like NumLock, Airplane Mode, and other system toggles

sourcery-ai[bot]
sourcery-ai bot reviewed Apr 7, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @18202781743 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using a constant for the left margin instead of a magic number.
  • It might be good to group the icon name changes together in a single commit for clarity.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sourcery-ai
Copy link

sourcery-ai bot commented Apr 7, 2025

Reviewer's Guide by Sourcery

This pull request updates the icons for several OSD types and adjusts the left margin of the text within the AppletItem in main.qml. The icon updates aim to improve visual clarity, while the margin adjustment refines the layout.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated icons for several OSD types to improve visual representation.
  • Updated the icon for 'NumLockOn' to 'osd_numeric_keypad_on'.
  • Updated the icon for 'NumLockOff' to 'osd_numeric_keypad_off'.
  • Updated the icon for 'AirplaneModeOn' to 'osd_airplane_on'.
  • Updated the icon for 'AirplaneModeOff' to 'osd_airplane_off'.
 panels/notification/osd/default/package/main.qml
Adjusted the left margin of the text within the AppletItem to refine the layout.
  • Reduced the left margin for the text to 16.
 panels/notification/osd/default/package/main.qml
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

mhduiy
mhduiy previously approved these changes Apr 7, 2025
View reviewed changes
mhduiy
mhduiy previously approved these changes Apr 7, 2025
View reviewed changes
@18202781743
chore: adjust UI for default osd
bdfea21 
update icons.
adjust margin between icon and text.

pms: BUG-311279
@deepin-ci-robot
Copy link

deepin-ci-robot commented Apr 7, 2025

deepin pr auto review

代码审查意见：

  1. 文件删除：

    • 删除了osd_airplane_mode_off.dci和osd_airplane_mode_on.dci文件，确认这是否是有意为之。如果这些文件不再需要，删除是合理的。如果这些文件被误删，需要恢复。

  2. 文件新增：

    • 新增了osd_airplane_off.dci和osd_airplane_on.dci文件，确认这些文件是否是必要的，并且文件名是否正确反映了其内容。

  3. 图标名称更改：

    • 将osd_keyboard_on.dci和osd_keyboard_off.dci更改为osd_numeric_keypad_on.dci和osd_numeric_keypad_off.dci，确认这是否符合UI/UX设计规范，并且这些更改是否已在其他相关文件中同步更新。

  4. 布局调整：

    • 在main.qml文件中，调整了Text组件的Layout.leftMargin值，从20更改为16。确认这个更改是否是为了改善用户体验，并且是否与其他组件的布局保持一致。

  5. 代码注释：

    • 代码中的一些注释使用了中文，这有助于理解代码的功能，但建议在代码中保持一致的注释语言，以避免混淆。

  6. 未使用的代码：

    • 删除了Item和Text组件中的一些未使用的Layout.fillWidth属性，这有助于清理代码，提高可读性。

  7. 文件权限：

    • 确保所有新增和修改的文件权限正确，特别是对于二进制文件，确保它们不会被意外修改。

  8. 代码风格：

    • 确保代码风格与项目中的其他代码保持一致，包括缩进、空格和换行等。

  9. 测试：

    • 在进行这些更改后，应该进行充分的测试，确保UI/UX没有受到影响，并且功能仍然正常工作。

  10. 文档更新：

    • 如果这些更改会影响用户文档或开发者文档，确保相应文档也得到更新。

总体来说，这些更改看起来是合理的，但需要确保所有相关的文件和文档都已更新，并且这些更改不会对现有功能产生负面影响。

@18202781743 18202781743 requested a review from mhduiy April 7, 2025 07:38
@deepin-ci-robot
Copy link

deepin-ci-robot commented Apr 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743
Copy link
Contributor Author

18202781743 commented Apr 7, 2025

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Apr 7, 2025

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 3d71c1a into linuxdeepin:master Apr 7, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@mhduiy mhduiy mhduiy approved these changes

@yixinshark yixinshark Awaiting requested review from yixinshark

@robertkill robertkill Awaiting requested review from robertkill

@BLumia BLumia Awaiting requested review from BLumia

@fly602 fly602 Awaiting requested review from fly602

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@18202781743 @deepin-ci-robot @mhduiy